On Fri, 16 Dec 2022 18:22:24 GMT, Adam Sotona <asot...@openjdk.org> wrote:

>> **This pull request is not intended for immediate integration to JDK 
>> mainline.**
>> 
>> This is root pull request with Classfile API implementation, tests and 
>> benchmarks initial drop into JDK.
>> 
>> Following pull requests consolidating JDK class files parsing, generating, 
>> and transforming 
>> ([JDK-8294957](https://bugs.openjdk.org/browse/JDK-8294957)) will chain to 
>> this one.
>> 
>> Classfile API development is tracked at:
>> https://github.com/openjdk/jdk-sandbox/tree/classfile-api-branch
>> 
>> Development branch of consolidated JDK class files parsing, generating, and 
>> transforming is at:
>> https://github.com/openjdk/jdk-sandbox/tree/classfile-api-dev-branch
>> 
>> Classfile API [JEP](https://bugs.openjdk.org/browse/JDK-8280389) and [online 
>> API 
>> documentation](https://htmlpreview.github.io/?https://raw.githubusercontent.com/openjdk/jdk-sandbox/classfile-api-javadoc-branch/doc/classfile-api/javadoc/java.base/jdk/classfile/package-summary.html)
>>  is also available.
>> 
>> Please take you time to review this non-trivial JDK addition.
>> 
>> Thank you,
>> Adam
>
> Adam Sotona has updated the pull request incrementally with two additional 
> commits since the last revision:
> 
>  - removal of Preview.java and TransPatterns.java patch
>    and enabled preview for java.base
>  - jdk.compiler ClassWriter patch to avoid writing PREVIEW_MINOR_VERSION to 
> classes participating in preview

src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/ClassWriter.java line 
1641:

> 1639:         if (preview.isEnabled() && preview.usesPreview(c.sourcefile)
> 1640:                 // do not write PREVIEW_MINOR_VERSION for classes 
> participating in preview
> 1641:                 && !preview.participatesInPreview(syms, c, 
> syms.java_base.unnamedPackage)) {

javac ClassWriter patch to do not write PREVIEW_MINOR_VERSION for classes 
participating in preview

-------------

PR: https://git.openjdk.org/jdk/pull/10982

Reply via email to