On Fri, 16 Dec 2022 18:22:24 GMT, Adam Sotona <asot...@openjdk.org> wrote:
>> **This pull request is not intended for immediate integration to JDK >> mainline.** >> >> This is root pull request with Classfile API implementation, tests and >> benchmarks initial drop into JDK. >> >> Following pull requests consolidating JDK class files parsing, generating, >> and transforming >> ([JDK-8294957](https://bugs.openjdk.org/browse/JDK-8294957)) will chain to >> this one. >> >> Classfile API development is tracked at: >> https://github.com/openjdk/jdk-sandbox/tree/classfile-api-branch >> >> Development branch of consolidated JDK class files parsing, generating, and >> transforming is at: >> https://github.com/openjdk/jdk-sandbox/tree/classfile-api-dev-branch >> >> Classfile API [JEP](https://bugs.openjdk.org/browse/JDK-8280389) and [online >> API >> documentation](https://htmlpreview.github.io/?https://raw.githubusercontent.com/openjdk/jdk-sandbox/classfile-api-javadoc-branch/doc/classfile-api/javadoc/java.base/jdk/classfile/package-summary.html) >> is also available. >> >> Please take you time to review this non-trivial JDK addition. >> >> Thank you, >> Adam > > Adam Sotona has updated the pull request incrementally with two additional > commits since the last revision: > > - removal of Preview.java and TransPatterns.java patch > and enabled preview for java.base > - jdk.compiler ClassWriter patch to avoid writing PREVIEW_MINOR_VERSION to > classes participating in preview Classfile API implementation is now ready for review. There is one integration obstacle - it heavily uses pattern switch language feature and that is still a preview. Part of history of this pull request are two different solutions (see https://github.com/openjdk/jdk/pull/10982/commits/c42dc3e4472e6e7b78607bcdbc26d8d09bde0349): 1. enable preview for compilation of java.base (without writing preview minor class versions into the affected classfiles) 2. or patch interim compiler to exclude pattern switch from preview features for JDK compilation I would prefer to choose one of the options and integrate Classfile API into JDK mainline ASAP, because of many waiting dependences (see [JDK-8294957](https://bugs.openjdk.org/browse/JDK-8294957)) and despite the perspective that pattern switch feature might be finalized soon. Thanks for your review. Adam ------------- PR: https://git.openjdk.org/jdk/pull/10982
