On Thu, 17 Aug 2023 00:37:55 GMT, Dean Long <dl...@openjdk.org> wrote:
>> Coleen Phillimore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Change size of op_index back. > > src/hotspot/share/utilities/elfFile.cpp line 1454: > >> 1452: return false; >> 1453: } >> 1454: uint8_t operation_advance = checked_cast<uint8_t>(adv); > > My reading of the spec is that operation_advance can be large. I suggest > reverting operation_advance changes and just do a checked_cast when assigning > op_index. I reverted it to uint32_t and we should file a bug if it needs to be larger, since the code is using 32 bit or smaller for this value. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/15233#discussion_r1296570904
