On Thu, 17 Aug 2023 01:57:46 GMT, David Holmes <dhol...@openjdk.org> wrote:
>> Coleen Phillimore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Change size of op_index back. > > src/hotspot/share/utilities/elfFile.hpp line 486: > >> 484: DwarfFile* _dwarf_file; >> 485: MarkedDwarfFileReader _reader; >> 486: uintptr_t _section_start_address; > > This seems suspicious - is this a 32-bit value or 64-bit? I see Dean indicated this is platform specific, but I don't know how. It sounds like this is a bug if it should be 64-bit. > src/hotspot/share/utilities/elfFile.hpp line 851: > >> 849: void reset_fields(); >> 850: // Defined in section 6.2.5.1 of the DWARF spec 4. >> add_to_address_register() must always be executed before set_index_register. >> 851: void add_to_address_register(uint8_t operation_advance, const >> LineNumberProgramHeader& header); > > Not clear how you decided/determined that `operation_advance` should always > be 8-bit? Never mind I see you reverted this while I was reviewing. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/15233#discussion_r1296598547 PR Review Comment: https://git.openjdk.org/jdk/pull/15233#discussion_r1296599004
