On Fri, 16 Aug 2024 11:52:25 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
> > Tangentially, I think we should start thinking about extended workflows > > that are not run by default PR-triggers, so you could potentially run them > > if you wanted for Alpine-specific fixes. This would making the decisions > > like this rather easy. > > I agree, we should really add that functionality. Then, as you say, it would > be a no-brainer to add Alpine as an opt-in build and/or build+test. > > If you are hesitant as well about adding this, maybe this is something we > should prioritize before accepting this. (And then only accepting this as a > non-default option.) > > It might be so simple as to not list it in the `default` field of the > platform selection part. > > @gdams Maybe you can test that? Revert line 39 in main.yml, and start the > test manually and specify alpine as a target. > > If that works fine, we can add some way for users to set their own defaults > by setting a GHA environment/repository variable. (Either an > "JDK_EXTRA_TARGETS" to just appent more to the default, or a "JDK_TARGETS" to > completely override, or both.) I'm not actually sure if line 39 is where we want to make the changes. I think we need to add some logic to this function to skip certain platforms by default when a push event is triggered: https://github.com/openjdk/jdk/blob/c6906eff9db8f7e7737c42af49ae4f2f6ad7b095/.github/workflows/main.yml#L77-L112 ------------- PR Comment: https://git.openjdk.org/jdk/pull/20577#issuecomment-2293726115
