On Mon, 19 Aug 2024 09:44:04 GMT, George Adams <gd...@openjdk.org> wrote:
>> Adds Alpine build CI job to the GitHub actions matrix. Currently this only >> builds hotspot. I can add tests too if people think that would be useful but >> for now I've left it as just build. > > George Adams has updated the pull request incrementally with two additional > commits since the last revision: > > - improve conditional logic > - try this Yes, this is somewhat more akin to what I was thinking. But I was actually thinking about a more encompassing rewrite of that method. First of all, GHA variables did not exist when that code were written, so they had to be secrets, even though it does not make sense in this context. These control variables should be changed from secrets to variables, or the code rewritten so it can support both. Secondly, I think there is a use-case for having both a variable which just appends to the default set of platforms/tests, and one that replaces the default value. Third, there has been requests to change what tests are run (e.g. tier-2) as well as which platforms are tested. I think it would be good to let such functionality tie in with any other changes in this area. But, just to be clear, I don't think it is necessary, nor even appropriate, for you to address any of these changes in this PR. In fact, I would have been happy with the previous iteration as well. But this version is okay as well, if you can move the exclude list to a more suited location. ------------- PR Comment: https://git.openjdk.org/jdk/pull/20577#issuecomment-2296576086
