On Mon, 19 Aug 2024 08:47:13 GMT, George Adams <gd...@openjdk.org> wrote:
> > For the future, I think we should try to figure out a way to allow users to > > define their own set of included checks persistently, but for now this is > > good. Since it will not run by default, I have no objections. > > I think this is the idea of these `JDK_SUBMIT_FILTER` and > `JDK_SUBMIT_PLATFORMS`: > > https://github.com/openjdk/jdk/blob/4a6cbe47daae82970c36c8cd86655581b2c59f59/.github/workflows/main.yml#L86-L92 > > Admittedly with my current setup this wouldn't work for Alpine. The only > other option I could think of is maintaining a list of "skip unless > explicitly defined" platforms in the `check_platform()` function. I'd be > happy to put a prototype together if you'd prefer this solution I found https://wiki.openjdk.org/display/skara/testing#Testing-Conditionallyenable/disablebuildsandtests which defines this process but unfortunately this has been broken for some time in GitHub actions as it treats the platform as a secret and redacts it's contents: <img width="604" alt="Screenshot 2024-08-19 at 10 21 21" src="https://github.com/user-attachments/assets/1f29aa51-caf9-4e31-a70e-8042175ca6bb";> I'll see if I can find a workaround that fixes this ------------- PR Comment: https://git.openjdk.org/jdk/pull/20577#issuecomment-2296086833
