On Mon, 19 Aug 2024 13:21:42 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
>> George Adams has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - improve conditional logic >> - try this > > .github/workflows/main.yml line 84: > >> 82: >> 83: # List of platforms to exclude by default >> 84: EXCLUDED_PLATFORMS=("alpine-linux-x64") > > I'm not to fond of declaring a list like this in the middle of a code body. > Perhaps you can set it up as a non-required workflow input with alpine as the > default value, declared next to the default list of platforms? @magicus do you want me to push this change? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20577#discussion_r1721971949