On Thu, 11 Sep 2025 12:13:04 GMT, Magnus Ihse Bursie <[email protected]> wrote:
>> In the static JDK image, a single humongous java executable is generated,
>> and no other launcher, such as javac. This makes it impossible to run our
>> jtreg tests, which assume these are present.
>>
>> The solution is fortunately simply: we just need to add a bunch of trivial
>> launchers, which are thin wrappers that execute the main java binary, with
>> the proper arguments. This will result in the same behavior as the normal
>> dynamic launchers, only that we will need to take the detour of launching
>> another process instead of calling directly into the JLI library.
>
> Magnus Ihse Bursie has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Remove debug code
src/java.base/windows/native/launcher/relauncher.c line 40:
> 38: static char* launcher_args[] = LAUNCHER_ARGS;
> 39:
> 40: char* quote_argument(char* arg) {
@RogerRiggs Would you mind scanning the quote_argument in the Windows launcher?
You've had to deal with this in the process code and I think good to get
another set of eyes.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24380#discussion_r2349554917
