On Mon, 15 Sep 2025 16:35:49 GMT, Alan Bateman <[email protected]> wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove debug code
>
> src/java.base/windows/native/launcher/relauncher.c line 40:
>
>> 38: static char* launcher_args[] = LAUNCHER_ARGS;
>> 39:
>> 40: char* quote_argument(char* arg) {
>
> @RogerRiggs Would you mind scanning the quote_argument in the Windows
> launcher? You've had to deal with this in the process code and I think good
> to get another set of eyes.
Looks looks good. The algorithm in the windows version of ProcessImpl.java is
the almost the same but the implementation is slightly different. But the
result is the same.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24380#discussion_r2349634869
