On Wed, 17 Sep 2025 19:27:57 GMT, Alexey Semenyuk <[email protected]> wrote:
>> Yes, I've read that blog post, tried to implement it and credited in the >> source code. :-) >> >> The discussion was if the executable name should be treated differently than >> the command line arguments. I've added code do explicitly do this, but I >> don't any longer recall why (this was originally developed back in like May >> or April, it's just been sitting on the shelf waiting for me to get to the >> finish line). I do recall that I ran into problems when I treated the >> executable name as any other argument though, so *something* special needs >> to be done about it. >> >> But reading this blog post again, it seems that it claims that the program >> name should be quoted the same way as well. I'll try to go back in time and >> check my notes, command line histories and old commits to see if I can >> figure out what kind of issue I ran into. Otherwise the correct solution >> seem to be to quote the program name the same way. > > Oh, my bad :) I didn't dive into the source code. I came across this > discussion and recalled a similar issue in the installer code. > > We quote the program name in the installer shims. No worries, that blog post is essential reading for anyone working with command line args on Windows, and it is a good thing that you try to spread knowledge about it. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24380#discussion_r2356550461
