On Fri, 17 Apr 2026 16:58:00 GMT, Naoto Sato <[email protected]> wrote:
> Removing obsolete options/code from CLDRConverter, which is now always emits > Java code in UTF-8 encoding. > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai). make/jdk/src/classes/build/tools/cldrconverter/CLDRConverter.java line 1096: > 1094: formatter.format("\\u%04x", (int)aChar); > 1095: } else { > 1096: if (aChar == 0x0022) { What about using the corresponding char literal (`'"'`) to make it easier to understand what this is escaping? Suggestion: if (aChar == '"') { (This is only a suggestion; I am not an OpenJDK member, feel free to ignore this comment.) ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30797#discussion_r3107009443
