On Sun, 19 Apr 2026 14:52:22 GMT, Marcono1234 <[email protected]> wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Refined comments for ASCII quotation marks
>
> make/jdk/src/classes/build/tools/cldrconverter/CLDRConverter.java line 1096:
>
>> 1094: formatter.format("\\u%04x", (int)aChar);
>> 1095: } else {
>> 1096: if (aChar == 0x0022) {
>
> What about using the corresponding char literal (`'"'`) to make it easier to
> understand what this is escaping?
>
> Suggestion:
>
> if (aChar == '"') {
>
>
> (This is only a suggestion; I am not an OpenJDK member, feel free to ignore
> this comment.)
Thanks. I added a comment explaining it is for ASCII quotation marks
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30797#discussion_r3112214887
