On Tue, 21 Apr 2026 08:30:14 GMT, Marcono1234 <[email protected]> wrote:
>> Thanks. I added a comment explaining it is for ASCII quotation marks
>
> Thanks, I think it would have been better to replace the `0x0022` with `'"'`
> (which would be functionality identical), but I assume you have your reasons
> why you did not want to do that.
>
> As side note: I just noticed that another possibility would be to merge this
> `"` handling with the other escaping logic in the `case` branches above,
> specifically `case '\'`, e.g.:
>
> ...
> case '\', '"':
> // Escape the char
> outBuffer.append('\');
> outBuffer.append(aChar);
> break;
> ...
>
>
> Though this was just a suggestion anyway, and this PR is already approved, so
> feel free to ignore.
I'd be happy to incorporate your suggested changes once you've signed the OCA
(I assumed you haven't, as you wrote "I am not an OpenJDK member." Please let
me know if that's not the case).
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30797#discussion_r3118835631
