On Tue, 21 Apr 2026 16:13:17 GMT, Naoto Sato <[email protected]> wrote:
>> Thanks, I think it would have been better to replace the `0x0022` with `'"'`
>> (which would be functionality identical), but I assume you have your reasons
>> why you did not want to do that.
>>
>> As side note: I just noticed that another possibility would be to merge this
>> `"` handling with the other escaping logic in the `case` branches above,
>> specifically `case '\'`, e.g.:
>>
>> ...
>> case '\', '"':
>> // Escape the char
>> outBuffer.append('\');
>> outBuffer.append(aChar);
>> break;
>> ...
>>
>>
>> Though this was just a suggestion anyway, and this PR is already approved,
>> so feel free to ignore.
>
> I'd be happy to incorporate your suggested changes once you've signed the OCA
> (I assumed you haven't, as you wrote "I am not an OpenJDK member." Please let
> me know if that's not the case).
I have not signed the OCA, however
- Skara forces users commenting on GitHub OpenJDK projects to accept the
[OpenJDK Terms of Use](https://openjdk.org/legal/tou/)[^1], see [this
example](https://redirect.github.com/openjdk/jextract/pull/284#issuecomment-3976397318),
which I have accepted in the past (otherwise all my comments here would be
censored)
- GitHub's Terms of Service require that [content submitted to a repository is
licensed under the license of the
repository](https://docs.github.com/en/site-policy/github-terms/github-terms-of-service#6-contributions-under-repository-license)
[^1]: I can't find any publicly available information about this Skara feature
(maybe there is OpenJDK-internal though), but there are [issues related to it
in the bug
tracker](https://bugs.openjdk.org/issues/?jql=project%20%3D%20Skara%20AND%20text%20~%20"%5C"TOU%5C"";)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30797#discussion_r3122728908
