On Fri, 24 Apr 2026 13:51:47 GMT, Leo Korinth <[email protected]> wrote:

> Add all g1 files that compiles with `$(CFLAGS_CONVERSION_WARNINGS)`. Remove 
> the old example 
> `g1Numa.cpp`, because I misspelled `g1NUMA.cpp` (that does not compile with 
> the warnings)
> 
> Eventually, after cleanups, there will only be a single expression left 
> ```$(call ExtendFlags, $(TOPDIR)/src/hotspot/share/gc/g1, \
>         %.cpp, _CXXFLAGS, $(CFLAGS_CONVERSION_WARNINGS)), ```
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

Just ignore this for now, I obviously need to do changes.

I think most of the problems will be solved by [8382920: Shenandoah: Do fewer 
implicit narrowing 
conversions](https://github.com/openjdk/jdk/pull/30896/changes#top)#30896. 
Includes will differ a bit with and without precompiled headers. 

Let us wait for it to be integrated.

One positive outcome of the current failures is that we can see that there is a 
difference between pch and non-pch builds. This means that extra warning flags 
will not invalidate precompiled headers (something that is also supported by 
the gcc documentation)

-------------

PR Comment: https://git.openjdk.org/jdk/pull/30924#issuecomment-4325635377
PR Comment: https://git.openjdk.org/jdk/pull/30924#issuecomment-4327559768

Reply via email to