On Fri, 24 Apr 2026 13:51:47 GMT, Leo Korinth <[email protected]> wrote:
> Add all g1 files that compiles with `$(CFLAGS_CONVERSION_WARNINGS)`. Remove > the old example > `g1Numa.cpp`, because I misspelled `g1NUMA.cpp` (that does not compile with > the warnings) > > Eventually, after cleanups, there will only be a single expression left > ```$(call ExtendFlags, $(TOPDIR)/src/hotspot/share/gc/g1, \ > %.cpp, _CXXFLAGS, $(CFLAGS_CONVERSION_WARNINGS)), ``` > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai). make/hotspot/lib/CompileJvm.gmk line 308: > 306: g1YoungGenSizer.cpp, _CXXFLAGS, $(CFLAGS_CONVERSION_WARNINGS)), \ > 307: $(call ExtendFlags, $(TOPDIR)/src/hotspot/share/gc/g1, \ > 308: jvmFlagConstraintsG1.cpp, _CXXFLAGS, > $(CFLAGS_CONVERSION_WARNINGS)), \ Would it be possible to collapse this a bit and reduce repetition by listing all the filters (i.e. filenames) in one ExtendFlags call? I think that would work at least. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30924#discussion_r3162714648
