On Wed, 29 Apr 2026 16:49:27 GMT, Erik Joelsson <[email protected]> wrote:
>> Leo Korinth has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains three additional >> commits since the last revision: >> >> - Fixes in master merged >> - remove trash file >> - G1: Enable stricter warning flags for g1 files > > make/hotspot/lib/CompileJvm.gmk line 308: > >> 306: g1YoungGenSizer.cpp, _CXXFLAGS, $(CFLAGS_CONVERSION_WARNINGS)), >> \ >> 307: $(call ExtendFlags, $(TOPDIR)/src/hotspot/share/gc/g1, \ >> 308: jvmFlagConstraintsG1.cpp, _CXXFLAGS, >> $(CFLAGS_CONVERSION_WARNINGS)), \ > > Would it be possible to collapse this a bit and reduce repetition by listing > all the filters (i.e. filenames) in one ExtendFlags call? I think that would > work at least. I think it is not possible (but please correct me if I am wrong). The goal is to reduce this to one call when everything in g1 is fixed. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30924#discussion_r3180520082
