Hello Daniel, David, Just FYI, this `age` thing was actually suggested by you earlier in this thread, but I will be more than happy to remove it. May I ask you if the very first patch in this thread makes more sense now?
Attached it just in case. If it looks better - I will amend man page with required info. Please let me know! Thank you, Fedor. On Thu, Jan 28, 2016 at 10:12 AM, Daniel Stenberg <dan...@haxx.se> wrote: > On Thu, 28 Jan 2016, David Drysdale wrote: > > Personally, I'd lean towards not including the age / reserved extension >> mechanism. None of the other structures that describe particular resource >> records have it, and the first/rest marker is just an accidental omission >> from the TXT structure, so just having a new, complete, structure seems >> sensible. >> > > However, I'm happy to defer to Daniel's opinion, so I'd suggest leaving >> as-is for now. >> > > I think I'm inclined to agree with you David. No other funtion has such a > mechanism so it'll just stand out as a weird anomaly. Even though I may > have introduced that thought previously in this thread, I don't think I'm > liking it very much here. Let's make an effort to make clean and > understandable function APIs and we deprecate (primarily by documenting > that fact) those that we replace with better ones. > > Then at some point in time we can just cut out the old ones and release > c-ares version 2 without the old cruft. > > - ares_data.c:163: I like to add a /* FALLTHROUGH */ comment for >> deliberate >> case fall through (I have a vague memory that it shuts up some lint >> warning too). >> > > Yes, for example: without that comment the Coverity scanner will warn for > it. > > -- > > / daniel.haxx.se >
-----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAABAgAGBQJTNIorAAoJEPsOEJWxeXmZTDAP/0BVAUgror62mPtpTb/VlO+o Y7HFycmhNJxkDMGtuwI1/KTzL4+juTq/7kLteBSyhlbHkxCO2ygYJYV9acNtuj3C Qb7KitslvAHWnzWhtWlfBALI0QOHxz5GIoFWQZcqnvRzHtL6AJLxKC1duEpFsEKW SwNuhCwO6oz3BaKw11L95GVFNacYwH3sdIs3ykUOgSv8itms36KxZI3mdqQdxxv7 o4NEFqcUsMxlPM7IDSHekXJuf6pN7lbxuhU2qllmUHiwz1qNGhGzD5JzNEqjlJNq ggyzD+j8EIXwmZ3R+JaKbdutzIzcioq5MwdxTDqx7TOn7UayRjksXFKwY3vTe0zE 1OtnMdRdS75AVULvaXp/D+ulDrT2Yxp84ScI/EVWaheI8nEXEdN/5DeKkdEGQhtS B+fS0+C6Qc/Z8MiBAVlmXE0AaEk5wZd1eFoMY996iZ4h/aZSoXwg8Wmi8ITOpAjK ApMZMA3evfhO+N0HpRS/++tTnE0pTUcmAYW1rCFtPSxJEnlXdOm/jIYqTIZCYDLF d2goef8gg4MbrOsHu7DKuPjC1+3UXdP3l84qsBlc89by2fvx08cF+YtTfEkYH7Ka 1NSRKJorshTDajziM2bwiUEr3KX6HV661ujUcbIxtNKVC+4nZ3JNYAwzePMyob7a C48VQpBCP0ITQRa+KP3x =9BGU -----END PGP SIGNATURE-----
0001-ares_parse_txt_reply-add-record_start-field.patch
Description: Binary data
