Hi Jan, On Wed, 11 Nov 2009, Jan Damborsky wrote:
> Hi Jean, Alok, > > could I please ask you to review fix for following bugs ? > > <http://defect.opensolaris.org/bz/show_bug.cgi?id=7966>7966 setting > 'livemode=text' is no-op for AI, should be removed from installadm(1M) > 8140 Fix for 6440 applied to x86 AI images would reduce x86 AI memory > consumption > > > Thank you very much, > Jan > > webrev: > http://cr.opensolaris.org/~dambi/bug-8140/ installadm-common.sh: lines 463-464: Sorry if I'm dense but I don't see why this check is needed. If x86.microroot exists, it also means that split 32/64 bit archives don't exist; so we should pick up the boot archive from /${BootLofs}/x86.microroot. Otherwise, pick it up from the appropriate platform directory. Which cases would this miss? installadm-common.sh: line 464: Is the "\" before $ISADIR really needed? ai_plat_setup.py: I wonder why we didn't catch this while testing 8347. Alok
