Hi Jean,

jeanm wrote:
> Jan Damborsky wrote:
>> Hi Jean,
>>
>> jeanm wrote:
>>> installadm-common.sh:
>>> Are we at all concerned with the case of an image that might exist 
>>> with the amd64 boot_archive a link to the 32 bit one?
>>
>> I am not sure how we could end up with this case -
>> you mean that boot archive with 64 bit stuff wouldn't exist
>> at all ?
> Yeah. Not sure if that's an issue or not.

I think it is another example of 'malformed AI image' scenario.

>>
>>> Is there any way of combining the two if's into one? Just seems a 
>>> little awkward to check for basically the same thing in two 
>>> different ways.
>>
>> Agreed - I have removed the first 'if' - it is redundant.
>> I have also added comment describing covered scenarios.
>>
>> The webrev has been updated accordingly.
> Looks good to me.

Thanks a lot !
Jan


Reply via email to