Hi Jan,

On Thu, 12 Nov 2009, Jan Damborsky wrote:

>> installadm-common.sh: lines 463-464: Sorry if I'm dense but
>> I don't see why this check is needed. If x86.microroot exists,
>> it also means that split 32/64 bit archives don't exist; so
>> we should pick up the boot archive from /${BootLofs}/x86.microroot.
>> 
>> Otherwise, pick it up from the appropriate platform directory.
>> Which cases would this miss?
>
> You are right. Too much 'ifs' as Jean also pointed out :-)
> I have removed one of them and added comment.
>
> The webrev has been updated accordingly.

Looks good.

>> ai_plat_setup.py: I wonder why we didn't catch this while testing
>> 8347.
>
> Creating that symlink was intentional - it was stop gap solution before fix 
> for 8140
> is integrated in order not to break 64bit XEN PV, as it scans following 
> locations for
> 64 bit boot archive:
>
> /boot/x86.microroot
> /boot/amd64/x86.microroot
> /platform/i86pc/amd64/boot_archive
>
>
> More details about XEN dependencies on install can be seen at:
>
> http://hub.opensolaris.org/bin/view/Community+Group+xen/install-depedencies

Thanks for explaining!

Alok

Reply via email to