Code review updated.
http://cr.opensolaris.org/~jeanm/slim_4127_3/
Tested: manifest file resume_from not there, valid, invalid, names and
numbers
-r valid, invalid names and numbers
-R
Mixing -r and manifest file with manifest file resume_from
valid and invalid and not there and -r valid and invalid.
Mixing -R and manifest file with manifest file resume_from
valid and invalid and not there.
Jean
Jack Schwartz wrote:
> Hi Jean.
>
> I agree with both of Karen's points, and have one of my own as well:
>
> usr/src/cmd/distro_const/distro_const.py:
>
> When -r is specified on the commandline, DC_verify_resume_step()
> verifies that the given step is valid. If -r is not specified on the
> commandline but a resume step is given in the manifest, I don't see
> DC_verify_resume_step() getting called. Add at line 152+ ?
>
> Thanks,
> Jack
>
> On 10/26/08 18:36, Jean McCormack wrote:
>> Can Jack and Karen please review the following
>>
>>
>> Defect:
>> http://defect.opensolaris.org/bz/show_bug.cgi?id=4127
>>
>> Webrev:
>> http://cr.opensolaris.org/~jeanm/slim_4127/
>>
>>
>> Jean
>> _______________________________________________
>> caiman-discuss mailing list
>> caiman-discuss at opensolaris.org
>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
>>
>
