Hi Barbara,

I didn't have an assigned section, so I reviewed the first 20 pages or so of 
the 
DC Guide and read through the manpage. Below are some general review comments, 
mostly minor in nature.

thanks,
Sue


DC Guide Comments
-----------------
p5
o using the instructions at Chapter 2 -> using the instructions in Chapter 2
o This tool takes an XML -> The tool takes an XML

p6
o you can build a SPARC image by using the automated installer
->
you can install a SPARC image by using the automated installer
o all cases of distro_constr should be changed to distro_const

p7
o all cases of distro_constr should be changed to distro_const
o you want to stop and test the image -> you want to stop and check the image

p8
o Seems like the last paragraph needs a header, since it isn't part of 
Checkpointing Options. Maybe something like "Getting Started" or "Next Steps".
o the instructions at Chapter 2 -> the instructions in Chapter 2

p10
o select the Get Software icon -> select the Add More Software icon
o /usr/bin/distro-const -> /usr/bin/distro_const (change dash to underscore)
o Under /usr/share/distro_const/slim_cd, it mentions "the default slim_cd.xml 
manifest file". That file isn't there - perhaps that should be slim_cd_x86.xml.
o You should also list the AI xml files:
/usr/share/distro_const/auto_install/ai_sparc_image.xml
/usr/share/distro_const/auto_install/ai_x86_image.xml

o At bottom of page, the link should be updated to 2009.06

p11
o What is the purpose of this Note? Are you recommending that the user install 
that package?

p13
o different name for xml file:
/usr/share/distro_const/slim_cd/slim_cd.xml -> 
/usr/share/distro_const/slim_cd/slim_cd_x86.xml
And do you want to also mention the AI manifest files?

p14
o (mid-page) Remove the Note. By the time the 2009.06 release goes out, the 
sparc packages will also be at http://pkg.opensolaris.org/release, same as for 
x86

p16
o references to boot-root should, for consistency, either all be "boot-root" as 
on this page or "boot root" as on p14 (see Caution) and p15

p18
o WRT: "See the section below about "Using the ManifestReader" on page 19"
Either remove the "below" or remove the "on page 19".

o for /usr/sbin/mkfile $TMP_DIR....
    mkfile expects a size argument. Perhaps someone more familiar with DC can 
suggest what the size should be.

p19
o following example from slim_cd.xml manifest file -> following example from 
slim_cd_x86.xml manifest file

p33
o update troubleshooting reference:
2008.11 Release Notes -> 2009.06 Release Notes



MAN Page Comments
-----------------
o Description Step 2 - missing leading / on usr/share....

o Description Step 2 - seems like there is now a choice of at least three 
manifest files to start from, one for slim_cd and two for ai:
/usr/share/distro_const/slim_cd/slim_cd_x86.xml
/usr/share/distro_const/auto_install/ai_sparc_image.xml
/usr/share/distro_const/auto_install/ai_x86_image.xml

o  Description, Step 3:
"See the Distro-Constructor guide" url points to 2008.11, needs 2009.06

o typo in name:
distro_constr -h
->
distro_const -h

o nits
remove extra spaces before "slim_cd.xml" in "Example 1", pfexec commands.

o SEE ALSO
2009/06 -> 2009.06



On 03/09/09 16:44, Barbara.Lundquist at sun.com wrote:
 > Install gang,
 >
 > The distribution constructor docs are available for review. See
 > * DistroConst.pdf
 > * distro_const(1M)
 >   at:
 > http://www.opensolaris.org/os/project/caiman/files/
 >
 > The primary review of these docs should be done by 3/17, although I'll
 > extent review a second week as needed.
 >
 > Tomorrow during install team meetings, I'll bring up the following
 > review questions. I hope we can assign contacts for me tomorrow to help
 > me with the various questions below and any others that come up over the
 > next week.
 >
 > Barbara
 >
 >

Reply via email to