DC-manifest.rng:
Lines 59-68: Does this mean that we now could have neither nm_img_params 
or nm_vming_params? It just
    looks to me like you modified the requirements for a live image 
build. Can you explain?

lines 65-68: My assumption is that you uncomment this if you want it? 
Correct? I believe the following comment does with this one.
lines 294-307: Haven't you made the definition of nm_vming_params a big 
comment?

DC_checkpoint.py:
Not PEP8 compliant. Feel free to call me since I've spent some time 
making some DC files so.


DC_tm.py -> im_pop.py:
It looks like you mostly copied DC_tm.py to im_pop.py. If so, it's 
easier for people to see the real
changes if you do a hg rename DC_tm.py im_pop.py

distro_const.py:
Not PEP8 compliant.

im_pop.py:
Not PEP8 compliant

vmc shell scripts:
I'll leave these for others


Jean

Glenn Lagasse wrote:
> The VMC project is proud to present it's code for your review.  You may
> access the webrev at:
>
> http://cr.opensolaris.org/~glagasse/slim_vmc/
>
> I'm also attaching the DC log file for a VMC run as well as the console
> output for the same run for the curious as to what this looks like in
> practice.
>
> The timeout for providing review comments is COB October 23rd, 2009.  If
> you need more time, please let me know.
>
> Thanks!
>
>   


Reply via email to