Karen Tung wrote: > Hi Jean, > > In DC_tm.py, you removed the assignment of default values in lines > 222-225 > and 391-394, I think we should still keep the check for None, in case the > manifest parsing module is not behaving correctly. I have to disagree. Those lines are the whole reason for this bug. If the manifest parsing module isn't doing what it is supposed to, that is a bug. We should fix that bug not add extra code "just in case this bug happens".
jean > > Everything else look fine. > > Thanks, > > --Karen > > Jean McCormack wrote: >> Please review: >> >> Defect: http://defect.opensolaris.org/bz/show_bug.cgi?id=4042 >> >> Webrev: http://cr.opensolaris.org/~jeanm/slim_4042/ >> >> Jean >> _______________________________________________ >> caiman-discuss mailing list >> caiman-discuss at opensolaris.org >> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >> >
