Jean McCormack wrote: > Karen Tung wrote: >> Hi Jean, >> >> In DC_tm.py, you removed the assignment of default values in lines >> 222-225 >> and 391-394, I think we should still keep the check for None, in case >> the >> manifest parsing module is not behaving correctly. > I have to disagree. Those lines are the whole reason for this bug. > If the manifest parsing module isn't doing what it is supposed to, > that is a bug. > We should fix that bug not add extra code "just in case this bug > happens". > Maybe I need to be more clear in my comment. When we check for None, we return error if it is None. We don't default it to any value like the existing code. This way, if the libraries our code calls misbehaves, it will be detected earlier, and our code will report the failure and exit without executing further just like we always check for the return value for system calls or other libraries.
Thanks, --Karen
