John,
On 4/4/12 2:27 PM, John Fischer wrote:
Drew,
I looked at AI and GUI. Mostly nits.
usr/src/cmd/auto-install/manifest/ai_manifest.xml
- how protective do we need to be with the chap
passwords? I am concerned that these will
start appearing in AI manifests in clear text.
It's OK for the CHAP password to appear unencrypted in the manifest and
transmitted over the wire unsecured. CHAP passwords aren't really
passwords in the traditional sense; they're used more for LUN masking
than authentication.
usr/src/cmd/distro_const/checkpoints/pre_pkg_img_mod.py
- To be consistent please add a comment to 524 or remove the comment
from line 729 and 773.
524 self.modify_dhcpagent()
...
729 # modify /etc/default/dhcpagent
730 self.modify_dhcpagent()
731
...
773 # modify /etc/default/dhcpagent
774 self.modify_dhcpagent()
775
Fixed.
usr/src/cmd/gui-install/src/disk_discovery_screen.py
- should this comment read as error #1?
319 # error #2 - required fields must be entered
usr/src/cmd/gui-install/src/disk_screen.py
- should this string be changed to reference iSCSI disk instead
of disk?
628 LOGGER.debug("Including disk: %s", disk.ctd)
I know these are trivial but I'm going to have Dermot comment on these
since there's also line 326 which is commented out likely from when we
changed the behavior of the Target LUN per Jesse's suggestion.
Thanks for looking!
-Drew
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
