On Apr 6, 2012, at 1:36 PM, Drew Fisher wrote: > Jesse, > > Thanks for the review! > > > On 4/5/12 11:40 AM, Jesse Butler wrote: >> >> Hey Drew- >> >> I've gone through the install_target stuff, looks good. Thanks for making >> that change, nice work. I just have two nits in install_target/pysical.py >> >> line 3438: >> nit - just for clarity's sake, maybe add an "otherwise, just build a list of >> all LUNs" to the comment > > Done. > >> >> line 3453: >> Does this code go away now? If not, should update the comment. > > Yep. The UEFI changes make that block unneeded. Removed! > > -Drew >
Ok, I'm all LGTM then. Good job on this! /jb _______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
