Sue,
Thanks for the review! See comments in line.
On 4/6/12 2:57 PM, Sue Sohn wrote:
Hi Drew and Dermot,
Mostly nits...
INSTALL_DISK_DISCOVERY_PANEL.txt
23,44 Note vs NOTE
Fixed.
disk_discovery_screen.py
42-54 alphabetize imports
Fixed.
60-85 might be nice to alphabetize these as well
None of the rest of the TI constants are alphabetized in the other
files. If it's a big deal to you, I can alphabetize them though.
gui_install_common.py
111 arguements
525 oppertunity
Fixed.
disk_selection.py
255 existance
Fixed.
discovery_selection.txt
3 suggested reword:
what kind of disks should be found and presented for selection
->
what kind of disks should be presented for selection
Fixed.
iscsi.txt
9,12 Note vs. NOTE
36 Would be good to show expanded CHAP acronym ala
INSTALL_DISK_DISCOVERY_PANEL.txt:83
Fixed.
iscsi.py
35-46 alphabetize imports
Fixed.
59-75, 78-86 alphabetize these groupings as well?
See above.
physical.py
3312 Would it be more clear to say "%s is not online and requires
manual servicing" or maybe tell the user what the current state is?
Added your suggested rewording.
3317 resovled
Fixed.
3318,3328, 3332 For these multiple argument strings. should you be
using %(key)s style (see 7154017, 7158566).
Bleh. At this point, I'm not terribly inclined to convert just 2-3
lines to using .format() while leaving the other 3500+ lines
uninspected. This is something we need to talk about as a team and
decide on a best practice (for us and maybe all of ON).
3427-3436 Is there any possibility that you could get an OS Device
Name line before a LUN line? If so, lun_num won't exist yet at 3431.
No, I don't think there is. Naturally, now that I've said that, this
code will traceback immediately in PIT after I push.
3573 seperated
3580 paramaters
Fixed. I am spel gud.
Thanks again!
-Drew
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
