Hi Jack,
LGTM. Thank you.
Takeshi
On 2012年06月13日 11:01, Jack Schwartz wrote:
Hi everyone.
Here is hopefully the final webrev for this wad. It includes a new bug for
removing indentation spacing. I included it here since indentation is
intertwined with other changes made earlier.
7176467 Remove all indentation spacing from localized strings in sysconfig and
text-install summary screens
Other changes remain the same.
New webrev and delta from previous webrev are both at:
https://cr.opensolaris.org/action/browse/caiman/schwartz/7131650_3/
As I understand, Mary is OK with original changes, and Karen is OK with the
changes if Takeshi-san is. Assuming this is the case, I'll wait especially for
Takeshi-san to bless.
Thanks,
Jack
On 06/07/12 23:48, Takeshi Asano wrote:
Hi Jack,
On 2012年06月08日 08:40, Jack Schwartz wrote:
:
2) I am concerned about the changes for 7161785. In there, you did concatenate
those
strings like they requested in the bug. However, you left all the blank spaces
in the strings.
I left a few blank spaces for indentation of an email address, and at the
beginning of lines just like what was there in the rest of the file.
I supposed those spaces are used to line up the strings in English. What will
the translators
do with the spaces? Is the person that filed the bug OK with leaving the spaces?
I have cc'ed Takeshi-san on this email to call the bug to his attention and get
his opinion.
I understand all consecutive spaces in the strings
are for indentation, rather than padding.
It's good to eliminate indentation from strings to translate,
though with a bit less priority than for the padding case, in general.
Regarding the strings being touched, 2nd and later ones could be able
to eliminate indentation e.g.
support_summary.append(" " + _(Telemetry will be registered with "
"My Oracle Support using email address:\n"))
support_summary.append(" %s" % support.mos_email)
support_summary.append(" " + _("MOS credentials NOT yet validated "
support_summary.append(" " + _("MOS credentials NOT yet validated "
(Please don't use "+" inside of _(). xgettext tool cannot handle it correctly.)
But regarding the first string, simple use of this approach will conflict
with what the bug report asks; to contain full sentence in single string.
I think use of the 1st string you proposed as is, or just moving
the leading spaces out of _(), and keep the other spaces precede
the "but will not be".
# BTW, it seems to me that the indentation is not in effect in actual
# display currently; maybe stripped off somewhere.
Thanks,
Takeshi
Thanks,
Jack
Thanks,
--Karen
On 06/06/12 16:36, Jack Schwartz wrote:
Hi everyone.
Here is a webrev of some fixes for OCM/ASR screens and one for removing the
add_drivers stanza from ai_manifest.xml.
https://cr.opensolaris.org/action/browse/caiman/schwartz/7131650_1/webrev/
Bug IDs:
7131650 <http://monaco.us.oracle.com/detail.jsf?cr=7131650> Temporarily remove add_drivers
stanza in ai_manifest.xml 7158078 <http://monaco.us.oracle.com/detail.jsf?cr=7158078> GUI
Install fails when bypassing Support registration 7171496
<http://monaco.us.oracle.com/detail.jsf?cr=7171496> installer summary screens should
reflect which of OCM and ASR are configured, if only one is
7174802 <http://monaco.us.oracle.com/detail.jsf?cr=7174802> Need to update the
vanity url in the S11U installers with respect to OCM
7161785 <http://monaco.us.oracle.com/detail.jsf?cr=7161785>
WPTG_TBT:Lint:CONCAT:Q&A204721:Solaris 11.1 install_s11 T13Y issue in
solaris_install_textinstall.po
Testing:
7158078: Ran GUI installer to the point just before the install with blanked
out email, password and password checkbox. Verified there were no more
tracebacks.
7171496 and 7161785: Ran GUI installer, text installer and sysconfig with
various combinations of email and password, and mimicking whether OCM and/or
ASR were absent from the system, to verify that the summaries were accurate.
(For example, if OCM isn't on the system, to only say ASR telemetry will be
sent, etc.)
7174802: Verified corrected links showed in live CD, sysconfig and
text-installer screens.
Python files are Pep8 clean.
Gate builds cleanly.
Thanks,
Jack
P.S. Dermot gets the credit for 7158078. I'm just his conduit for testing and
pushing.
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
