I just wanted to point out a few things to anyone in the know. Barry is currently doing work for me, fixing up the project he is working on, and that he has talked about here. I am not the original coder on this project. A contractor was brought in for this. For a variety of reasons, the people responsible for explaining coding standards and reviewing code, seem to have done neither (again not me). The contractor was sold to us as a 'senior developer' with extensive experience. The contractor in question has, to my knowledge, never posted to this list, so no one here is likely to know him/her. The contractor in question does not do CF work anymore. (there IS a God!) I have worked previously on this project a little, after the original contractor but before Barry. Most of my time was spent equally pulling my hair out and fixing mind bogglingly stupid code. Barry was warned before he started that the code he would be working on was very bad. (clearly he thought I was exagerating!) This project was not a badly evolved and misbegotten prototype stretched beyond its life or intent. This was a built from scratch, designed, prototyped project, with screen layouts, business rules, etc, and a very healthy original development schedule. Admittedly, the original documentation was messy and not well layed out, but it was all there and there were also people to ask if anything wasn't clear.
I just wanted to point these things out as I didn't want anyone to think for 1 second that I was responsible for this awful code, and I also didn't want anyone considering doing work for us (we're hiring!) to be concerned that this was the norm or even a small chunk of the type of code we have. It is a single, one off, really painfully awful piece of code amongst a sea of otherwise average code. Regards Darren On Mar 14, 12:59 pm, "barry.b" <[EMAIL PROTECTED]> wrote: > (I thought the teacher in me was well and truly burnt to a crisp... > aparently not...) > > hyperthetical > > * you're finishing off someone elses project, it's only a couple of > weeks of work > * that person is someone that you know/see around the traps > * you know you're not the world's gift to coding but trying to follow > best practices has put you in good stead for years (and reduced the > amount of obscure bugs) > * the code is full of (lets say) less than optomial practices eg > - SELECT * > - reuse of the variable "ID" on the same page for diffent usages/ > contexts > - hardly any use of scopes (esp URL and FORM) with lots of using > isDefined() > - not a cfqueryparam to be seen. > > do you > > a) shoot them when next you meet then dance on their grave. > b) make a semi formal list of what's wrong and why then bail them up > to go on "chapter-and-verse" about it > c) make an informal comment on next meeting that it "had a few rough > edges" and leave it at that > d) keep your mouth shut, your head down and keep saying to yourself > "it's only for a short while"... > > thoughts? --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "cfaussie" group. To post to this group, send email to cfaussie@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/cfaussie?hl=en -~----------~----~----~----~------~----~------~--~---
