On Wed, Jul 15, 2015 at 2:28 PM, Reid Kleckner <r...@google.com> wrote: > rnk added a subscriber: rnk. > rnk added a comment. > > Seems reasonable. > > > ================ > Comment at: include/clang/Basic/LangOptions.def:81 > @@ -80,2 +80,3 @@ > LANGOPT(ObjC2 , 1, 0, "Objective-C 2") > +LANGOPT(SceExt , 1, 0, "Sony PlayStation(R) extensions") > BENIGN_LANGOPT(ObjCDefaultSynthProperties , 1, 0, > ---------------- > How do you guys feel about "sony" vs. "sce"? I know we abbreviated Microsoft > to MS, but I think a lot of folks don't know that the full name of the > particular company involved is "Sony Computer Entertainment". If > -fsce-extensions is already used in build systems, I'm OK leaving the flag as > is. I'm mostly concerned with SceExt.
I would strongly prefer something more human-readable than SceExt (such as SonyExt), and weakly prefer sony instead of sce for the flag. The rest of the patch LGTM, modulo personally understanding requirements/intent better. ~Aaron > > > http://reviews.llvm.org/D11207 > > > > > _______________________________________________ > cfe-commits mailing list > cfe-commits@cs.uiuc.edu > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits _______________________________________________ cfe-commits mailing list cfe-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits