leonardchan added a comment.

In https://reviews.llvm.org/D50616#1202034, @ebevhan wrote:

> I think I've mentioned this before, but I would like to discuss the 
> possibility of adding a target hook(s) for some of these operations 
> (conversions, arithmetic when it comes). Precisely matching the emitted 
> saturation operation is virtually impossible for a target.


Sorry I forgot to address this also. Just to make sure I understand this 
correctly since I haven't used these before: target hooks are essentially for 
emitting target specific code for some operations right? Does this mean that 
the `EmitFixedPointConversion` function should be moved to a virtual method 
under `TargetCodeGenInfo` that can be overridden and this is what get's called 
instead during conversion?


Repository:
  rC Clang

https://reviews.llvm.org/D50616



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to