MaskRay added inline comments.
================ Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2685 + if (Args.hasArg(OPT_fsemantic_interposition)) + Opts.SemanticInterposition = 1; + ---------------- ` Opts.SemanticInterposition = Args.hasArg(OPT_fsemantic_interposition);` ================ Comment at: clang/test/CodeGen/semantic-interposition.c:1 +// RUN: %clang_cc1 -emit-llvm -fsemantic-interposition -pic-level 0 %s -o - | FileCheck %s -check-prefix=CHECK-NOPIC-NOPIE +// RUN: %clang_cc1 -emit-llvm -fsemantic-interposition -pic-level 1 %s -o - | FileCheck %s -check-prefix=CHECK-PIC-NOPIE ---------------- Add a file-level comment what configurations produce SemanticInterposition ================ Comment at: clang/test/CodeGen/semantic-interposition.c:8 + +// CHECK-NOPIC-NOPIE-NOT: "SemanticInterposition" +// CHECK-PIC-NOPIE: !{{[0-9]+}} = !{i32 1, !"SemanticInterposition", i32 1} ---------------- `CHECK-NOPIC-NOPIE-NOT` and `CHECK-PIC-PIE-NOT` can be combined (e.g. `INTERPOSE:` vs `NO-INTERPOSE-NOT:` ) ================ Comment at: llvm/test/Transforms/Inline/inline-semantic-interposition.ll:1 +; RUN: opt < %s -inline -S | FileCheck %s + ---------------- excess space Add a comment what happened here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72829/new/ https://reviews.llvm.org/D72829 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits