serge-sans-paille marked 2 inline comments as done. serge-sans-paille added inline comments.
================ Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2685 + if (Args.hasArg(OPT_fsemantic_interposition)) + Opts.SemanticInterposition = 1; + ---------------- MaskRay wrote: > ` Opts.SemanticInterposition = Args.hasArg(OPT_fsemantic_interposition);` That was on purpose, so that we're backward compatible with existing situation. Without the flag, the genrated .ll doesn't differ. That's less explicit though. Does it make sense to you? ================ Comment at: llvm/test/Transforms/Inline/inline-semantic-interposition.ll:1 +; RUN: opt < %s -inline -S | FileCheck %s + ---------------- MaskRay wrote: > excess space > > Add a comment what happened here. I'm not sure about the excess space comment, but comment added. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72829/new/ https://reviews.llvm.org/D72829 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
