serge-sans-paille marked 3 inline comments as done. serge-sans-paille added inline comments.
================ Comment at: clang/lib/CodeGen/CodeGenModule.cpp:488 + if (Context.getLangOpts().SemanticInterposition && + (Context.getLangOpts().PICLevel && !Context.getLangOpts().PIE)) + // Require various optimization to respect semantic interposition. ---------------- MaskRay wrote: > MaskRay wrote: > > The parentheses can be deleted. > An alternative is to move the PIC/PIE logic to > lib/Frontend/CompilerInvocation.cpp > > Then we should be able to use `if > (Context.getLangOpts().SemanticInterposition)` here :+1: like that one Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72829/new/ https://reviews.llvm.org/D72829 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
