dougpuob added inline comments.
================
Comment at: clang-tools-extra/clang-tidy/bugprone/ReservedIdentifierCheck.h:44
llvm::Optional<FailureInfo>
- GetDeclFailureInfo(const StringRef &TypeName, const NamedDecl *Decl,
+ getDeclFailureInfo(const StringRef &TypeName, const NamedDecl *Decl,
const SourceManager &SM) const override;
----------------
dougpuob wrote:
> aaron.ballman wrote:
> > Given that the other functions in the class use the wrong style of casing,
> > we should probably leave this declaration alone so it doesn't become
> > locally inconsistent.
> Do you mean create another function with three parameters for it?
I think I got it. Keep consistent even it is wrong style of casting.
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86671/new/
https://reviews.llvm.org/D86671
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
