dougpuob marked 8 inline comments as done. dougpuob added a comment. I fixed all review suggestions from @aaron.ballman, @Eugene.Zelenko, and @njames93, Thank you. But I still can't sure I did everything correct.
I encountered a problem when I use `arc diff` or `arc diff --update D86671`, Arcanist will create a new Review(D86838 <https://reviews.llvm.org/D86838>) to Phabricator. This makes me to update the diff on the web interface. Another behavior I can't sure do I did it right. I will pull the latest master then create a new local branch(my-new-branch) then manually merge the diff from previous branch(my-prev-branch). After this I use `git diff HEAD~1 -U999999 > mypatch.patch`, then update the diff, `mypatch.patch` file to Phabricator. Is it right? Or is there a smarter way to do it? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86671/new/ https://reviews.llvm.org/D86671 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
