jhenderson added a comment. Not that I have anything particularly against this, but won't this likely rot fairly rapidly? It's not like LLVM is even on C++17 let alone C++20 yet, so trying to make it work like the latter when it's just going to break again seems a bit like wasted effort to me.
================ Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:805-817 + return IsASCII ? "^" : (const char *)u8"\u2548"; case LineChar::RangeMid: - return IsASCII ? "|" : u8"\u2503"; + return IsASCII ? "|" : (const char *)u8"\u2503"; case LineChar::RangeEnd: - return IsASCII ? "v" : u8"\u253b"; + return IsASCII ? "v" : (const char *)u8"\u253b"; case LineChar::LabelVert: + return IsASCII ? "|" : (const char *)u8"\u2502"; ---------------- This seems unrelated to comparison checking? ================ Comment at: llvm/unittests/ADT/STLExtrasTest.cpp:465 // Check fancy pointer overload for unique_ptr + // Parenthesizing to_address to avoid ADL finding std::to_address std::unique_ptr<int> V2 = std::make_unique<int>(0); ---------------- Nit: trailing full stop. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78938/new/ https://reviews.llvm.org/D78938 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits