BRevzin added inline comments.
================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:805-817
+ return IsASCII ? "^" : (const char *)u8"\u2548";
case LineChar::RangeMid:
- return IsASCII ? "|" : u8"\u2503";
+ return IsASCII ? "|" : (const char *)u8"\u2503";
case LineChar::RangeEnd:
- return IsASCII ? "v" : u8"\u253b";
+ return IsASCII ? "v" : (const char *)u8"\u253b";
case LineChar::LabelVert:
+ return IsASCII ? "|" : (const char *)u8"\u2502";
----------------
jhenderson wrote:
> This seems unrelated to comparison checking?
> This seems unrelated to comparison checking?
It is unrelated. But In C++20, `u8` literals become their own type so this no
longer compiled and I wanted to ensure that I could actually run the tests.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78938/new/
https://reviews.llvm.org/D78938
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
