MyDeveloperDay added a comment.

I'm just going to say this here, but LLVM doesn't like the use of braces on 
single lines (I don't actually like that myself, but I go with the convention 
when I remember),

but this is followed only if the reviewer catches it, but by and large its 
super easy for them to get missed, it took me seconds to find an example..

I would love to see the end for the need for the "elide braces" comment in code 
reviews, by having an ability to "RemoveBraces"

i.e. this feature should be able to remove the `{}` in this case

  // Defaults that differ when not C++.
  if (Language == FormatStyle::LK_TableGen) {
    LLVMStyle.SpacesInContainerLiterals = false;
  }


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95168/new/

https://reviews.llvm.org/D95168

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to