kiranchandramohan accepted this revision. kiranchandramohan added a comment. This revision is now accepted and ready to land.
LGTM. In the call on Monday, it was mentioned that the original users of the flang script have moved on to using a custom driver. It will be a good idea to, -> wait for the author of the original script and the throwaway driver, @sscalpone. -> clarify that execution is still restricted to developers via a flag. We hope to open it to users later in the year. My personal preference for the renaming is `flang-to-external-fc` since it is not specific to gfortran. ================ Comment at: flang/tools/flang-driver/CMakeLists.txt:51 -install(TARGETS flang-new DESTINATION "${CMAKE_INSTALL_BINDIR}") +# For backwords compatibility +add_flang_symlink(flang-new flang) ---------------- Nit: backwords -> backwards Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125788/new/ https://reviews.llvm.org/D125788 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits