kiranchandramohan added a comment. In D125788#3523408 <https://reviews.llvm.org/D125788#3523408>, @shraiysh wrote:
>> With this change the flang driver will not generate an executable unless it >> is built with an option. > > Okay, thank you for the clarification. Is this a cmake option and? Are we > documenting this somewhere except this patch summary, like on the flang > documentation or something? Apologies if this a repetition to what you meant > by clarifying that it is available via a flag. I think it is a driver flag `-flang-experimental-exec`. I was only requesting the add this information to the patch summary. If you feel it should be present somewhere else then please add a separate comment. Some users might have been blindly running `flang` before without being aware that the script was calling an external compiler to generated code/executable. This change introduces the lowering flow and the users might see different results, -> TODO messages for 2003 and above features. -> Unexpected ICEs or miscomparisons. -> Not producing an executable. In D125788#3523443 <https://reviews.llvm.org/D125788#3523443>, @rouson wrote: > I think this is an exciting step. I hope it gets approved. Although it's > technically true that this could appear to be a regression for current flang > script users, the ultimate compilation currently happens by invoking an > external compiler so most current flang script users can eliminate the > regression by simply calling the external compiler. The exception would be > if the current flang script user specifically wants flang's parsing > capabilities for checking code correctness (do we know if anyone is using the > flang script that way?) or for testing the parser (which I presume can still > happen by other means). It might be nice to simply rename the current script > so those who want it can simply change the name they use to invoke it. Yes, the user can use `flang-to-external-fc` if they want the old flow. But this change might be a surprise for the user hence the request to add the relevant information to the summary. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125788/new/ https://reviews.llvm.org/D125788 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
