craig.topper added inline comments.
================ Comment at: clang/lib/Headers/immintrin.h:257 +/* FIXME: Change these When _Float16 type is supported */ +#if defined(__AVXNECONVERT__) && defined(__AVX512FP16__) ---------------- Is this FIXME still relevant? Don't we support _Float16 with SSE2 now? ================ Comment at: llvm/include/llvm/Support/X86TargetParser.def:204 X86_FEATURE (AVX512FP16, "avx512fp16") +X86_FEATURE (AVXNECONVERT, "avxneconvert") X86_FEATURE (AVXVNNI, "avxvnni") ---------------- Extra space before "avxneconvert" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135930/new/ https://reviews.llvm.org/D135930 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
