RKSimon added a comment. Possibly rename the x86-64-* test files to *-64 (and *-32 equivalent) so that the 32/64 bit files are closer together for tracking (and to help avoid bitrot).
================ Comment at: clang/lib/Headers/immintrin.h:257 +/* FIXME: Change these When _Float16 type is supported */ +#if defined(__AVXNECONVERT__) && defined(__AVX512FP16__) ---------------- pengfei wrote: > FreddyYe wrote: > > pengfei wrote: > > > craig.topper wrote: > > > > Is this FIXME still relevant? Don't we support _Float16 with SSE2 now? > > > _Float16 is supported with SSE2, but maybe we need to move `__m128h`, > > > `__m256h` out of avx512fp16intrin.h > > Yes. This is a redundant FIXME. > I have moved FP16/BF16 vector types out of original header files. rGe0fb01e9 > There should be no dependency to FP16 and BF16 feature now. Update to this? ``` #if !(defined(_MSC_VER) || defined(__SCE__)) || __has_feature(modules) || \ (defined(__AVXNECONVERT__) && defined(__AVX512FP16__)) ``` ================ Comment at: llvm/test/MC/X86/x86-64-avx-ne-convert-att.s:1 +// RUN: llvm-mc -triple x86_64-unknown-unknown --show-encoding %s | FileCheck %s + ---------------- x86-64-avx-ne-convert-intel.s ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135930/new/ https://reviews.llvm.org/D135930 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits