FreddyYe marked 5 inline comments as done. FreddyYe added a comment. THX for reviews!
================ Comment at: clang/lib/Headers/immintrin.h:257 +/* FIXME: Change these When _Float16 type is supported */ +#if defined(__AVXNECONVERT__) && defined(__AVX512FP16__) ---------------- pengfei wrote: > craig.topper wrote: > > Is this FIXME still relevant? Don't we support _Float16 with SSE2 now? > _Float16 is supported with SSE2, but maybe we need to move `__m128h`, > `__m256h` out of avx512fp16intrin.h Yes. This is a redundant FIXME. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135930/new/ https://reviews.llvm.org/D135930 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
