craig.topper added inline comments.
================ Comment at: clang/lib/Basic/Targets/X86.cpp:781 + Builder.defineMacro("__AVXVNNIINT8__"); + Builder.defineMacro("__AVXVNNIINT8_SUPPORTED__"); if (HasAVXVNNI) ---------------- Why is this define needed? ================ Comment at: clang/lib/Basic/Targets/X86.cpp:971 .Case("xsaveopt", true) + .Case("avxvnniint8", true) .Default(false); ---------------- This appears to have been in alpabetical order before. ================ Comment at: clang/lib/Headers/immintrin.h:257 +#if defined(__AVXVNNIINT8_SUPPORTED__) +#if !(defined(_MSC_VER) || defined(__SCE__)) || __has_feature(modules) || \ ---------------- Why is this define needed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135938/new/ https://reviews.llvm.org/D135938 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits