RKSimon added inline comments.
================ Comment at: clang/docs/ReleaseNotes.rst:553 - Fix 32-bit ``__fastcall`` and ``__vectorcall`` ABI mismatch with MSVC. +- Support ISA of ``AVX-VNNI-INT8``. ---------------- Please add a bullet list of the added intrinsics ================ Comment at: clang/lib/Headers/avxvnniint8intrin.h:32 + +static __inline__ __m256i __DEFAULT_FN_ATTRS256 +_mm256_dpbssd_epi32(__m256i __W, __m256i __A, __m256i __B) { ---------------- Please add doxygen descriptions for each intrinsic ================ Comment at: llvm/test/MC/Disassembler/X86/avx-vnni_int8-att.txt:1 +# RUN: llvm-mc --disassemble %s -triple=i686 | FileCheck %s + ---------------- I think we'd be better off merging the att/intel test files and using --check-prefix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135938/new/ https://reviews.llvm.org/D135938 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits