skan added inline comments.

================
Comment at: llvm/lib/Target/X86/X86InstrInfo.td:3028
+          (ins i32mem:$dstsrc1, GR32:$dstsrc2, GR32:$src3, ccode:$cond),
+          "cmp${cond}xadd\t{$src3, $dst, $dstsrc1|$dstsrc1, $dst, $src3}",
+          [(set GR32:$dst, (X86cmpccxadd addr:$dstsrc1, GR32:$dstsrc2, 
GR32:$src3, timm:$cond))]>,
----------------
+1 for craig. Usually if the input is tied to ouput, it should be the 1st 
input. These two instructions use a new Format MRMDestMem4VOp3CC rather than an 
existing one, I belive it won't increase the complexity.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135933/new/

https://reviews.llvm.org/D135933

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to